Upgrade dependencies #118
Merged
Upgrade dependencies #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slices.SortedFunc now lives in the std lib, and has gotten a slightly different API; the cmp func no longer returns a bool but an int so that comparisons can distinguish equality from higher and lower, which isn't possible with bool.
There is an issue with using go 1.22; we need to use 1.22.0 or .1. The error is: go: download go1.22 for linux/amd64: toolchain not available It should work to download go1.22.1 toolchain.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
===========================================
- Coverage 72.65% 61.70% -10.96%
===========================================
Files 63 77 +14
Lines 6301 7426 +1125
===========================================
+ Hits 4578 4582 +4
- Misses 1416 2540 +1124
+ Partials 307 304 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hanish520
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to Go 1.22 and updates all dependencies.
Fixes #117